-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query No Results: Add Border & Spacing Support #64601
base: trunk
Are you sure you want to change the base?
Query No Results: Add Border & Spacing Support #64601
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +213 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Flaky tests detected in e92d47e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10439107945
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @shail-mehta 👍
This is mostly working for me although I encountered an issue on the frontend where the block doesn't appear to have the correct box sizing to allow its parent to enforce a fixed width.
✅ Global styles apply correctly
✅ Block instance styles override global styles
✅ Styles apply consistently between editor and frontend
✅ Default display of spacing and border controls match
❓ Box sizing allows parent to enforce width
General Testing | Box Sizing Issue |
---|---|
Screen.Recording.2024-08-20.at.1.04.39.PM.mp4 |
Screen.Recording.2024-08-20.at.1.08.07.PM.mp4 |
Thanks for the Feedback. I will check this issue. |
What?
Add border and Spacing support to the
Query No Results
block.Part of #43247
Why?
Query No Results
block is missing border and Spacing support.How?
Add the border and Spacing support in block.json.
Testing Instructions
Query No Results
block's border and Spacing is Configurable via Global Styles.Query No Results
block and Apply the border Styles and Spacing.Query No Results
block styles take precedence over global Styles.Query No Results
block borders and Spacing display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-and-spacing-support-in-query-no-result-block.mp4